Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hybrid-search.mdx fix column name on documents table, fixes #26364 #26365

Merged
merged 3 commits into from
May 22, 2024

Conversation

oliviermills
Copy link
Contributor

The function uses doc_vector but table is setup with embedding so changed it to doc_vector

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Update text in doc

What is the current behavior?

What is the new behavior?

See issue #26364

The function uses `doc_vector` but table is setup with `embedding` so changed it to `doc_vector`
Copy link

vercel bot commented May 15, 2024

@oliviermills is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@charislam
Copy link
Contributor

Thanks @oliviermills! Could you update the column description below to match as well?

@fsansalvadore fsansalvadore requested a review from gregnr May 22, 2024 14:33
@gregnr
Copy link
Member

gregnr commented May 22, 2024

Good catch @oliviermills - I think embedding better represents the column than doc_vector though - let's update the function to say embedding vs vice versa (remove doc_vector references)

@oliviermills
Copy link
Contributor Author

Good catch @oliviermills - I think embedding better represents the column than doc_vector though - let's update the function to say embedding vs vice versa (remove doc_vector references)

Sure happy to change it. I used doc_vector as I am seeing more and more use of multi-column vectors in RAG applications and we tend to name things vec_xxx or xxx_vec . That said this is a simple one so clarity trumps nomenclature! Will change it

back to `embedding` as col name
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:36pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:36pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:36pm
studio-staging ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:36pm
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 6:36pm

@gregnr gregnr enabled auto-merge (squash) May 22, 2024 18:31
@gregnr gregnr merged commit 6bf236c into supabase:master May 22, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants