Remove unused code that is already being removed in minified build #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -366,7 +359,7 @@ AFRAME.registerComponent('environment', { | |||
| this.environmentData.playArea != oldData.playArea || | |||
| this.environmentData.flatShading != oldData.flatShading || | |||
| this.environmentData.groundDensity != oldData.groundDensity || | |||
| this.environmentData.groundFrequency != oldData.groundFrequency | |||
| this.environmentData.groundFrequency != oldData.groundFrequency || | |||
There was a problem hiding this comment.
Oh shoot I missed that in my review of #97 thanks for catching that.
|
Thank you! |
|
Published aframe-environment-component 1.3.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a build using
npm run dist, the following warnings are logged:This PR addresses all three of them by removing the offending code. It is technically possible for a user to depend on
enviroGetSettingswhen using the non-minified build, but a quick search on GitHub didn't show any usages. Since it's already absent from the minified build, it would be consistent to remove it in the non-minified version as well.