Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DependencyInjection] Improve error message when a class in not instantiable during auto-discovery #54890

Open
wants to merge 1 commit into
base: 7.2
Choose a base branch
from
Open

[DependencyInjection] Improve error message when a class in not instantiable during auto-discovery #54890

wants to merge 1 commit into from

Conversation

HMRDevil
Copy link
Contributor

@HMRDevil HMRDevil commented May 11, 2024 •
edited by nicolas-grekas

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #53651
License MIT

See #53651

@HMRDevil HMRDevil requested a review from dunglas as a code owner May 11, 2024 18:45
@carsonbot carsonbot added this to the 5.4 milestone May 11, 2024
nicolas-grekas
nicolas-grekas reviewed May 16, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about doing just this?
Note that this should target 7.2: it's not a bugfix but an improvement.

src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas modified the milestones: 5.4, 7.2 May 16, 2024
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] fix-53651 [DependencyInjection] Improve error message when a class in not instantiable during auto-discovery May 16, 2024
@HMRDevil HMRDevil changed the base branch from 5.4 to 7.1 May 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
DependencyInjection Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HMRDevil @nicolas-grekas @carsonbot