Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): use TAURI_ENV_TARGET_TRIPLE to determine the current platform-specific config #9646

Merged
merged 4 commits into from
May 28, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 3, 2024

closes #9607

@amrbashir amrbashir requested a review from a team as a code owner May 3, 2024 02:30
@amrbashir amrbashir force-pushed the fix/codegen/read-all-configs branch from b3c2638 to 9c5b49a Compare May 3, 2024 03:29
@amrbashir amrbashir changed the title fix(codegen): read all platform config files fix(codegen): use TAURI_ENV_TARGET_TRIPLE to determine the current platform-specific config May 3, 2024
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the env instruction

println!("cargo:rustc-env=TAURI_ENV_TARGET_TRIPLE={target_triple}");

does not work if the codegen is triggered inside the build script, it also needs a std::env::set_var instruction along it

.changes/tauri-codegen-use-correct-env.md Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit ccc3ea7 into dev May 28, 2024
29 checks passed
@lucasfernog lucasfernog deleted the fix/codegen/read-all-configs branch May 28, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Platform-Specific Configuration seems broken
2 participants