-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use evidence period when pruning (backport #9505) #9506
base: release/v0.37.1
Are you sure you want to change the base?
Conversation
* Added logic so when pruning, the evidence period is taken into consideration and only deletes unecessary data (cherry picked from commit abbeb91) # Conflicts: # CHANGELOG_PENDING.md # go.sum # state/execution.go
I understood this as an improvement to current behavior. |
v0.37 isn't exactly a past branch. Perhaps we can still add it there but drop the backport to v0.34? |
I would agree with this approach. However, after creating the backport PR to v0.37.x, please hold it until we're done with the first release. Reason is that we are not planning to redo the 200-node test, so we need a QA-tested v0.37.x. release to fall back to |
Yup agree |
Thanks. In the end, my understanding is that we decided in today's meeting that we'll create a feature branch from v0.37.x where we can merge all these backports until we cut v0.37.0, and then immediately after merge back the branch |
This is set for v0.37.1 (i.e. do not merge until after v0.37.0) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: E7A9A |
It doesn't seem like this can be backported directly because it relies on changes from #9443, which are Go API-breaking changes. |
This is an automatic backport of pull request #9505 done by Mergify.
Cherry-pick of abbeb91 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com