-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coap_refactoring_yml #10768
Closed
Closed
coap_refactoring_yml #10768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvayka
reviewed
May 14, 2024
@@ -110,6 +110,7 @@ edges.enabled=false | |||
# Transports disabled to speed up the context init. Particular transport will be enabled with @TestPropertySource in respective tests | |||
transport.http.enabled=false | |||
transport.mqtt.enabled=false | |||
coap.enabled=true | |||
transport.coap.enabled=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this one is left?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
nickAS21
requested review from
ashvayka and
YevhenBondarenko
and removed request for
ViacheslavKlimov
May 14, 2024 14:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
In all *.yml on CE and PE dtls settings should look like this:
In TbCoapDtlsSettings itself there should not be transport either, as it is a common structure for different services.
General checklist
Back-End feature checklist