Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show the textselection quickbar for videos #8252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not show the textselection quickbar for videos #8252

wants to merge 1 commit into from

Conversation

andrewnicols
Copy link

@andrewnicols andrewnicols commented Nov 9, 2022 •
edited

Related Ticket:

Description of Changes:

  • Similar to images, when selecting a video, it does not make sense to show the text selection tools. A video cannot be bolded, italicised, etc.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):

@andrewnicols andrewnicols requested a review from a team as a code owner November 9, 2022 12:46
@andrewnicols
Copy link
Author

Any hcance of a PR on this @spocke? Happy to rebase etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Community PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewnicols @TheSpyder