TINY-10916: Transparent color is converted into #00000 #9649

ArvinJ-H · 2024-05-15T07:08:11Z

Related Ticket:
TINY-10916

Description of Changes:

Added a seperate if statement to cover the edge case of transparent

Pre-checks:

Changelog entry added
Tests have been added (if applicable)
Branch prefixed with feature/, hotfix/ or spike/

Review:

Milestone set
~~Docs ticket created (if applicable)~~

GitHub issues (if applicable):
#9391

modules/tinymce/src/core/main/ts/api/html/Styles.ts

.changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml

modules/tinymce/src/core/test/ts/browser/html/StylesTest.ts

.changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml

modules/tinymce/src/core/main/ts/api/html/Styles.ts

Co-authored-by: Andrew Herron <thespyder@programmer.net>

modules/tinymce/src/core/test/ts/browser/html/StylesTest.ts

modules/tinymce/src/core/main/ts/api/html/Styles.ts

TheSpyder

I think this will make a lot of people happy 👍

modules/tinymce/src/core/main/ts/api/html/Styles.ts

modules/acid/src/main/ts/ephox/acid/api/colour/RgbaColour.ts

.changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml

Co-authored-by: spocke <spocke@moxiecode.com>

TheSpyder · 2024-05-21T07:01:12Z

modules/acid/src/main/ts/ephox/acid/api/colour/RgbaColour.ts

-const fromString = (rgbaString: string): Optional<Rgba> => {
-  if (rgbaString === 'transparent') {
-    return Optional.some(rgbaColour(0, 0, 0, 0));
+const getColorFormat = (colorString: string): string => {


This return should've been a sum type, not a string.

All I really wanted was some sort of function to run rgbRegex.test - not a full "get format" method when we only ever want to check one of the conditions...

* TINY-10916: Convert transparent to fully transparent black in Styles.ts * TINY-10916: Add changelog * TINY-10916: Prevent transparent from been converted * TINY-10916: Add and refactor tests * Update .changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml Co-authored-by: Andrew Herron <thespyder@programmer.net> * TINY-10916: Add more test * TINY-10916: Add more tests * TINY-10916: Update rgba regex to do exact match. * TINY-10916: Remove transparent string check (WIP) * TINY-10916: Rever rgba regex to rgb regex * TINY-10916: Lint fix * TINY-10916: Remove global match in rgb regex * TINY-10916: Refactor code, add support and test for new format * Update tinymce-TINY-10916-2024-05-15.yaml Co-authored-by: spocke <spocke@moxiecode.com> * TINY-10916: Update rgba regex * TINY-10916: Add RgbaColour test * TINY-10916: Update rgba regex and test --------- Co-authored-by: Andrew Herron <thespyder@programmer.net> Co-authored-by: spocke <spocke@moxiecode.com>

* TINY-10916: Convert transparent to fully transparent black in Styles.ts * TINY-10916: Add changelog * TINY-10916: Prevent transparent from been converted * TINY-10916: Add and refactor tests * Update .changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml * TINY-10916: Add more test * TINY-10916: Add more tests * TINY-10916: Update rgba regex to do exact match. * TINY-10916: Remove transparent string check (WIP) * TINY-10916: Rever rgba regex to rgb regex * TINY-10916: Lint fix * TINY-10916: Remove global match in rgb regex * TINY-10916: Refactor code, add support and test for new format * Update tinymce-TINY-10916-2024-05-15.yaml * TINY-10916: Update rgba regex * TINY-10916: Add RgbaColour test * TINY-10916: Update rgba regex and test --------- Co-authored-by: Andrew Herron <thespyder@programmer.net> Co-authored-by: spocke <spocke@moxiecode.com>

* TINY-10897: Bumped version for next patch release * TINY-10974: fix tests for new Firefox version (126) (#9666) (#9668) * TINY-10974: fix tests fro new Firefox version (126) * TINY-10974: add comment * TINY-10974: typo * TINY-10904: now polaris manage acronyms correctly (#9671) * TINY-10904: now polaris manage acronyms correctly * TINY-10904: improve test * TINY-10904: add changelog entry * TINY-10904: [test] fix tests * TINY-10904: fix error in rebase * TINY-10904: typo * TINY-10904: improve test * TINY-10904: [TEST] improve preformance * TINY-10904: removed doplication * TINY-10904: refactor * TINY-10904: refactor * TINY-10904: refactor without mutable boolean * TINY-10904: remove useless comment * TINY-10916: Transparent color is converted into #00000 (#9649) (#9670) * TINY-10916: Convert transparent to fully transparent black in Styles.ts * TINY-10916: Add changelog * TINY-10916: Prevent transparent from been converted * TINY-10916: Add and refactor tests * Update .changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml * TINY-10916: Add more test * TINY-10916: Add more tests * TINY-10916: Update rgba regex to do exact match. * TINY-10916: Remove transparent string check (WIP) * TINY-10916: Rever rgba regex to rgb regex * TINY-10916: Lint fix * TINY-10916: Remove global match in rgb regex * TINY-10916: Refactor code, add support and test for new format * Update tinymce-TINY-10916-2024-05-15.yaml * TINY-10916: Update rgba regex * TINY-10916: Add RgbaColour test * TINY-10916: Update rgba regex and test --------- Co-authored-by: Andrew Herron <thespyder@programmer.net> Co-authored-by: spocke <spocke@moxiecode.com> * TINY-10936: Prepare changelog for release (#9682) * TINY-10936: Prepare changelog for release * TINY-10936: Recover polaris change log * TINY-10936: Update changelog --------- Co-authored-by: Spocke <spocke@moxiecode.com> Co-authored-by: lorenzo-pomili <pomili.lorenzo85@gmail.com> Co-authored-by: Andrew Herron <thespyder@programmer.net>

ArvinJ-H added 2 commits May 15, 2024 17:03

TINY-10916: Convert transparent to fully transparent black in Styles.ts

ce45083

TINY-10916: Add changelog

f685381

ArvinJ-H requested a review from a team as a code owner May 15, 2024 07:08

ArvinJ-H requested review from spocke, TheSpyder and hamza0867 May 15, 2024 07:08

ArvinJ-H added this to the 7.2.0 milestone May 15, 2024

ArvinJ-H requested review from a team, ltrouton, shanmen-tiny and danoaky-tiny and removed request for a team May 15, 2024 07:08

spocke requested changes May 15, 2024

View reviewed changes

modules/tinymce/src/core/main/ts/api/html/Styles.ts Outdated Show resolved Hide resolved

.changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml Outdated Show resolved Hide resolved

modules/tinymce/src/core/test/ts/browser/html/StylesTest.ts Outdated Show resolved Hide resolved

TheSpyder reviewed May 15, 2024

View reviewed changes

.changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml Outdated Show resolved Hide resolved

modules/tinymce/src/core/main/ts/api/html/Styles.ts Outdated Show resolved Hide resolved

ArvinJ-H and others added 3 commits May 16, 2024 13:16

TINY-10916: Prevent transparent from been converted

2c31a48

TINY-10916: Add and refactor tests

cf55e81

Update .changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml

5cada9e

Co-authored-by: Andrew Herron <thespyder@programmer.net>

ArvinJ-H requested review from spocke and TheSpyder May 16, 2024 03:17

tiny-ben-tran approved these changes May 16, 2024

View reviewed changes

modules/tinymce/src/core/test/ts/browser/html/StylesTest.ts Outdated Show resolved Hide resolved

modules/tinymce/src/core/test/ts/browser/html/StylesTest.ts Show resolved Hide resolved

ArvinJ-H added 2 commits May 16, 2024 15:37

TINY-10916: Add more test

ade0e55

TINY-10916: Add more tests

d588491

TheSpyder requested changes May 16, 2024

View reviewed changes

modules/tinymce/src/core/main/ts/api/html/Styles.ts Outdated Show resolved Hide resolved

ArvinJ-H added 5 commits May 17, 2024 15:29

TINY-10916: Update rgba regex to do exact match.

ed58339

TINY-10916: Remove transparent string check (WIP)

b820ace

TINY-10916: Rever rgba regex to rgb regex

4ed8e84

TINY-10916: Lint fix

71f91b5

TINY-10916: Remove global match in rgb regex

645d468

ArvinJ-H requested a review from TheSpyder May 17, 2024 06:21

ltrouton approved these changes May 19, 2024

View reviewed changes

TheSpyder approved these changes May 20, 2024

View reviewed changes

modules/tinymce/src/core/main/ts/api/html/Styles.ts Outdated Show resolved Hide resolved

TINY-10916: Refactor code, add support and test for new format

49208ad

spocke approved these changes May 20, 2024

View reviewed changes

modules/acid/src/main/ts/ephox/acid/api/colour/RgbaColour.ts Show resolved Hide resolved

.changes/unreleased/tinymce-TINY-10916-2024-05-15.yaml Outdated Show resolved Hide resolved

ArvinJ-H and others added 4 commits May 20, 2024 20:18

Update tinymce-TINY-10916-2024-05-15.yaml

08229f2

Co-authored-by: spocke <spocke@moxiecode.com>

TINY-10916: Update rgba regex

9646771

TINY-10916: Add RgbaColour test

e6eedbe

TINY-10916: Update rgba regex and test

a5d65ec

ArvinJ-H merged commit c1ecd27 into main May 21, 2024
3 checks passed

ArvinJ-H deleted the feature/TINY-10916 branch May 21, 2024 05:46

TheSpyder reviewed May 21, 2024

View reviewed changes

TheSpyder linked an issue May 29, 2024 that may be closed by this pull request

👍 force_hex_color - Converts background-color:transparent to background-color:#000000 (black) #9391

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TINY-10916: Transparent color is converted into #00000 #9649

TINY-10916: Transparent color is converted into #00000 #9649

ArvinJ-H commented May 15, 2024 •

edited

TheSpyder left a comment

TheSpyder May 21, 2024

TINY-10916: Transparent color is converted into #00000 #9649

TINY-10916: Transparent color is converted into #00000 #9649

Conversation

ArvinJ-H commented May 15, 2024 • edited

TheSpyder left a comment

Choose a reason for hiding this comment

TheSpyder May 21, 2024

Choose a reason for hiding this comment

ArvinJ-H commented May 15, 2024 •

edited