Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): new Radio component #6910

Draft
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented May 13, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 66.54%. Comparing base (1008db8) to head (8dd3aff).

Files Patch % Lines
packages/frontend/component/src/ui/radio/radio.tsx 2.43% 40 Missing ⚠️
packages/frontend/component/src/utils/with-unit.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           catsjuice/fix/ui-storybook-body-scroll    #6910       +/-   ##
===========================================================================
+ Coverage                                   40.23%   66.54%   +26.31%     
===========================================================================
  Files                                         414      585      +171     
  Lines                                        7772    27224    +19452     
  Branches                                     1293     2546     +1253     
===========================================================================
+ Hits                                         3127    18116    +14989     
- Misses                                       4418     8840     +4422     
- Partials                                      227      268       +41     
Flag Coverage Δ
server-test 77.22% <ø> (?)
unittest 40.07% <18.18%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the catsjuice/fix/ui-storybook-body-scroll branch 2 times, most recently from c58ca84 to 03104cd Compare May 20, 2024 01:26
@EYHN EYHN changed the base branch from catsjuice/fix/ui-storybook-body-scroll to canary May 20, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant