Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): replace the loading state written in useState with useDebouncedValue #6925

Merged
merged 1 commit into from
May 16, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 14, 2024

close TOV-856

refactor(core): replace the loading state written in useState with useDebouncedState

fix(core): cloudSvg obscures toggle button

Copy link

graphite-app bot commented May 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review May 14, 2024 07:36
Copy link
Member Author

JimmFly commented May 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@JimmFly JimmFly requested a review from pengx17 May 14, 2024 07:37
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.58%. Comparing base (c7ddd67) to head (b8612f3).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6925      +/-   ##
==========================================
- Coverage   66.65%   66.58%   -0.07%     
==========================================
  Files         582      582              
  Lines       27384    27384              
  Branches     2573     2572       -1     
==========================================
- Hits        18252    18233      -19     
- Misses       8862     8881      +19     
  Partials      270      270              
Flag Coverage Δ
server-test 77.33% <ø> (-0.10%) ⬇️
unittest 39.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly requested a review from pengx17 May 14, 2024 11:00
@JimmFly JimmFly changed the title refactor(core): replace the loading state written in useState with useDebouncedState refactor(core): replace the loading state written in useState with useDebouncedValue May 14, 2024
Copy link

graphite-app bot commented May 16, 2024

Merge activity

…eDebouncedValue (#6925)

close TOV-856

refactor(core): replace the loading state written in useState with useDebouncedState

fix(core): cloudSvg obscures toggle button
@graphite-app graphite-app bot merged commit b8612f3 into canary May 16, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0514/refactor branch May 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants