Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): refine element toolbar ui #7064

Merged
merged 1 commit into from
May 21, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented May 15, 2024

Closes: AFF-1084

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) May 21, 2024 6:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 6:55am

Copy link

graphite-app bot commented May 15, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from c793c8b to 0b33c5b Compare May 15, 2024 12:55
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 0b33c5b to 728a51f Compare May 15, 2024 15:12
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 728a51f to a57378c Compare May 15, 2024 15:32
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from a57378c to 0b85dcf Compare May 15, 2024 15:54
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 0b85dcf to 2324fc1 Compare May 15, 2024 17:25
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 2324fc1 to 9cd4234 Compare May 16, 2024 09:20
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 9cd4234 to 6f1260a Compare May 16, 2024 11:41
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 6f1260a to 9329b32 Compare May 16, 2024 12:45
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 9329b32 to cd35718 Compare May 16, 2024 13:11
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from cd35718 to 8eabd53 Compare May 16, 2024 13:24
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 8eabd53 to 0375442 Compare May 16, 2024 13:35
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 0375442 to 7696ec1 Compare May 16, 2024 14:14
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 7696ec1 to e070cc2 Compare May 16, 2024 14:48
@Svaney-ssman
Copy link

The only issue is all the dividers and borders should be 0.5px wide, others all look good to me👍🏻

@fundon
Copy link
Contributor Author

fundon commented May 21, 2024

The only issue is all the dividers and borders should be 0.5px wide, others all look good to me👍🏻

Check the border and dropdown menu. Thanks.

Copy link

@Svaney-ssman Svaney-ssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOOD

@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch 2 times, most recently from a2bdfac to 1d9d3be Compare May 21, 2024 06:27
@fundon fundon force-pushed the 05_15-refine-element-toolbar-ui branch from 1d9d3be to e6a4ae3 Compare May 21, 2024 06:40
@fundon fundon self-assigned this May 21, 2024
@fundon fundon added the merge label May 21, 2024
Copy link

graphite-app bot commented May 21, 2024

Merge activity

  • May 21, 2:42 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 21, 2:47 AM EDT: fundon added this pull request to the Graphite merge queue.
  • May 21, 2:55 AM EDT: fundon merged this pull request with the Graphite merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants