Adding max import

[JachymPutta]

Pull Request Template

Checklist

• Confirmed that run-checks all script has been executed. -- run-check all gives a bunch of syntax errors
• Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Followed the steps described in contributor-book

Testing

Ran the tests manually cargo test max

[laggui]

Thanks for helping on the ONNX track!

If you look at the Max operator spec, it actually corresponds to the element-wise maximum between two tensors. This is equivalent to tensor.max_pair(other) or torch.maximum(tensor, other).

Going through your implementation, it seems to correspond to ReduceMax which is already implemented.

[JachymPutta]

Oh, you're right, my bad, let me fix that

[laggui]

Oh, you're right, my bad, let me fix that

It's all good 🙏

Honestly the ONNX spec can be quite confusing.. and there's a bunch of ops 😅

[JachymPutta]

Should be fixed!

[codecov]

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.41%. Comparing base (1073752) to head (131b2f6).
Report is 10 commits behind head on main.

Files	Patch %	Lines
crates/burn-import/src/burn/node/binary.rs	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   86.61%   86.41%   -0.21%     
==========================================
  Files         700      734      +34     
  Lines       83423    85607    +2184     
==========================================
+ Hits        72258    73978    +1720     
- Misses      11165    11629     +464     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[laggui]

🚀 🚀

LGTM! Thanks for the addition 🙂