Throw relevent error when query didn't match any selection rule #21904
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Resource group can be applied to things other than users (e.g. query type or source) - the new error message would be wrong then. |
|
@mosabua Can you suggest something better which is accurate yet more clear? |
mosabua
reviewed
May 31, 2024
| @@ -118,7 +118,7 @@ public void submit(ManagedQueryExecution queryExecution, SelectionContext<C> sel | |||
| public SelectionContext<C> selectGroup(SelectionCriteria criteria) | |||
| { | |||
| return configurationManager.get().match(criteria) | |||
| .orElseThrow(() -> new TrinoException(QUERY_REJECTED, "Query did not match any selection rule")); | |||
| .orElseThrow(() -> new TrinoException(QUERY_REJECTED, "User does not belong to any enabled resource group")); | |||
There was a problem hiding this comment.
Maybe
No matching resource group found with configured selection rules. No resources for query processing available.
Or only part of that even.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message can be more significant which will help user to understand the query failure reason.
Fixes #21895
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: