Apply workaround for JDK-8329528 #21999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/jdk-22-gc-workaround
branch
from
d09992c
to
b88e723
Compare
findepi
reviewed
May 16, 2024
...rc/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeCompatibility.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 16, 2024
...launcher/src/main/resources/docker/presto-product-tests/conf/presto/etc/jvm-pre-jdk22.config
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
May 16, 2024
losipiuk
approved these changes
May 16, 2024
wendigo
force-pushed
the
serafin/jdk-22-gc-workaround
branch
4 times, most recently
from
ea3cf0d
to
9b9238d
Compare
electrum
reviewed
May 16, 2024
...ng/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/util/Test.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jdk-22-gc-workaround
branch
from
9b9238d
to
77f6ce1
Compare
losipiuk
reviewed
May 17, 2024
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
May 17, 2024
wendigo
force-pushed
the
serafin/jdk-22-gc-workaround
branch
from
77f6ce1
to
f92d504
Compare
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.openjdk.org/browse/JDK-8329528
G1NumCollectionsKeepPinned: "After how many GCs a region has been found pinned G1 should give up reclaiming it."Fixes #21989
This flag defaults to 8: https://github.com/openjdk/jdk22u/blob/f5ce46f27e5489234d1305e0573e42898c9e9e32/src/hotspot/share/gc/g1/g1_globals.hpp#L327
More info:
https://github.com/openjdk/jdk22u/blob/f5ce46f27e5489234d1305e0573e42898c9e9e32/src/hotspot/share/gc/g1/g1CollectionSet.cpp#L370