Fix the initialization of projects in Homebrew-managed installations #6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested review from
waltflanagan and
kwridan
and removed request for
a team
pepicrft
commented
May 21, 2024
| @@ -57,7 +57,7 @@ public final class TemplatesDirectoryLocator: TemplatesDirectoryLocating { | |||
| share/ | |||
| Templates | |||
| */ | |||
| bundlePath.parentDirectory.appending(try! RelativePath(validating: "share/Templates")), | |||
| bundlePath.parentDirectory.appending(try! RelativePath(validating: "share")), | |||
There was a problem hiding this comment.
The line below, path.appending(component: Constants.templatesDirectoryName), is adding the /Templates component to the path.
Closed
pepicrft
added
the
changelog:fixed
fortmarek
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5921
Short description 📝
It turns out that the candidate that we were using for looking up
inittemplates in a Homebrew installation was wrong. This PR fixes it.How to test the changes locally 🧐
You'll have to build Tuist, reproduce a Homebrew installation with the binary in it, and then run
tuist init.Contributor checklist ✅
mise run lint:fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry