Docs: fix StackBlitz icon link examples #39799
Open
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes into account the issue reported in #39499 (the issue has been closed by OP but is still there in our documentation).
This PR supersedes #39505 based on @louismaximepiton and @mdo suggestions (#39505 (comment) and #39505 (comment))
Contrary to what's been done in #39505, this PR modifies the Icon Link page to embed the needed SVGs instead of using their references used elsewhere and not accessible from StackBlitz.
@louismaximepiton suggested using the second example in Alerts Icons. It can be challenged obviously, but I've rather used the first example which seemed closer to what I would do in a real project by default (of course it also depends on the global usage of these SVGs on the website, if they're used at different places, etc.).
The only drawback that I can see would when we'd want to change the "box-seam", "arrow-right" and "clipboard" globally in the documentation, it might be difficult to spot these usages here.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #39499