Add types to auth.py
#2033
Open
Add types to auth.py
#2033
+41
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Jan 14, 2023
| @@ -117,8 +124,8 @@ class OAuthHandler(OAuth1UserHandler): | |||
| Use :class:`OAuth1UserHandler` instead. | |||
| """ | |||
|
|
|||
| def __init__(self, consumer_key, consumer_secret, access_token=None, | |||
There was a problem hiding this comment.
This is probably not that important, but maybe we could use a better a way of deprecating old name classes here. See this comment on why it could be problematic, and a few options given in the SO thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there's no code formatting applied to this library. We might want to use
isortand a code formatter (e.gblack), as type hints addition will require a lot of imports.