refactor: renamed query-builder/RelationIdLoader.ts to QueryStrategyRelationIdLoader.ts #10857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Prior to this pull request, there were 2 classes named
RelationIdLoader
, in:This caused me some confusion recently.
The first one was referenced in src/data-source/DataSource.ts but otherwise not really used, so the usage has been removed in this pull request. It was also referenced in src/query-builder/SelectQueryBuilder.ts but renamed to
QueryStrategyRelationIdLoader
when importing:typeorm/src/query-builder/SelectQueryBuilder.ts
Line 11 in e7649d2
Hence it made sense to me to rename the first
RelationIdLoader
toQueryStrategyRelationIdLoader
, to match what it was already being renamed to anyway.Pull-Request Checklist
master
branchnpm run format
to apply prettier formattingnpm run test
passes with this change -- N/A - seecircleci
testsFixes #0000
-- N/A