New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change smallcaps
into an element function
#3981
Conversation
51216be
to
f3b899f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add some testcases to verify the behavior? If so, how can I add testcases?
The only existing smallcaps test is in tests/suite/text/smallcaps.typ
. You can add a new test there by adding another --- smallcaps-... ---
line there and adding your test code below. For instructions on how to run the tests, see the README.md in tests
.
Should documentation on smallcaps be changed? If so, I can add examples about the set/show rules on smallcaps.
We could add a second example showing how to use a custom font, i.e. #show smallcaps: set text(font: "..")
and adjust the Note
in the docs.
03b64e7
to
1e4d24b
Compare
Hi @laurmaedje , I've made the requested changes to this PR and was hoping you could find time for another review when convenient. Thank you! |
smallcaps
into element functionsmallcaps
into an element function
Thanks for your contribution! |
Description
Different from
upper
andlower
,smallcaps
is not always supported by selected font (for example, default font in math equation). In my view,smallcaps
is more likeemph
,strong
, etc. so I suggest it should be element function (#3977 ).This pr closes #3977 and maybe can help those who want to use
smallcaps
in math equations (#3138 ).Usage
With this feature, users can customize
smallcaps
behavior withset
/show
rules:TODO?
smallcaps
be changed? If so, I can add examples about theset
/show
rules onsmallcaps
.