Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whitespace being stripped from generateJSON #5158

Merged
merged 1 commit into from
May 24, 2024

Conversation

asiraky
Copy link
Contributor

@asiraky asiraky commented May 15, 2024

Changes Overview

Allows the options to be supplied to the DOM parser which allows one to supply (among other options) preserveWhitespace: true to the parser. There is an outstanding bug where whitespace is being stripped when using generateJSON. This makes importing data into tiptap impossible (for me).

Implementation Approach

Added the parameter as an optional parameter so its entirely opt in.

Testing Done

Ran this on my project and it solved the issue regarding whitespace.

Verification Steps

Ran this on my project and it solved the issue regarding whitespace.

Additional Notes

Checklist

  • I have renamed my PR according to the naming conventions. (e.g. feat: Implement new feature or chore(deps): Update dependencies)
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#4432

Copy link

netlify bot commented May 15, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit da9d62f
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66454bf8cbbed7000822fb8e
😎 Deploy Preview https://deploy-preview-5158--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@nperez0111 nperez0111 merged commit ae14557 into ueberdosis:main May 24, 2024
14 checks passed
Dalcvi pushed a commit to Dalcvi/tiptap that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants