New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML config file cleanups #10163
base: main
Are you sure you want to change the base?
YAML config file cleanups #10163
Conversation
…ards compatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10163 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 122 122
Lines 15579 15585 +6
=======================================
+ Hits 11686 11691 +5
- Misses 3893 3894 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…into yaml_clean
Note Changes to be made as recommend by @Laughing-q
This should result in only having 10 YAML files instead of the 19. |
Combining |
@Burhan-Q Hey I attempted to simplify the PR a little bit:
What do you think? |
@Laughing-q Thank you for helping out in this! I definitely like moving SPP to the neck definition, I think that makes a lot of sense. Should we do that with all the models for consistency (I know it probably isn't critical)? Also, I'm wondering about changing the model key definition to: yolov8: [*backbone, *neck, *detect ]
As long as the order is maintained (which I think it should), then the step for removing the old keys could be avoided. I can test this later if you don't get a chance to sooner. I forgot about the YOLOv3 YAML, thank you! Overall I agree with the improvements, as it should simplify things a lot. Sometimes I'm too close to the problem and I end up failing to see something trivial, which is why I always appreciate your input! 🚀 |
@Burhan-Q Yes I actually tried the |
pytests
for compatibility with new formatpytests
(wasn't clear if this was missing or not, but seemed like a good test to include).pytest report
Note output here displays YAML for display and troubleshooting purposes, but this change was not included in this PR
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Simplified and reorganized the YOLOv8 model configurations for better clarity and modularity.
📊 Key Changes
🎯 Purpose & Impact