Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py - add all keys in check_det_dataset() #10300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MatD3mons
Copy link

@MatD3mons MatD3mons commented Apr 24, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvement in dataset path settings to support more flexibility in configurations.

πŸ“Š Key Changes

  • Refactoring dataset paths setup: The loop iterating over dataset keys ("train", "val", "test", "minival") has been refactored to dynamically consider all keys in the dataset's dictionary except for certain specified keys ("nc", "yaml_file", "names", "path").

🎯 Purpose & Impact

  • Enhanced Flexibility: This change allows dataset configurations to be more flexible and not limited to predefined keys. It automatically adapts to any keys present in the dataset's configuration, making it easier to manage and extend datasets with custom splits or additional metadata.
  • Potential User Impact: Users dealing with custom datasets no longer need to conform strictly to a predetermined set of keys for their dataset splits. This could simplify the process of integrating diverse datasets and may reduce errors related to dataset configuration compliance.

πŸš€ This update is a step towards making the functionality more robust and user-friendly, particularly for those working with diverse or unconventional datasets.

Copy link

github-actions bot commented Apr 24, 2024

CLA Assistant Lite bot All Contributors have signed the CLA. βœ…

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @MatD3mons, thank you for submitting an Ultralytics YOLOv8 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/ultralytics main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Verify all YOLOv8 Continuous Integration (CI) checks are passing.
  • βœ… Update YOLOv8 Docs for any new or updated features.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

See our Contributing Guide for details and let us know if you have any questions!

@MatD3mons
Copy link
Author

I have read the CLA Document and I sign the CLA

@Burhan-Q Burhan-Q added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants