New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output predictor logs #12659
base: main
Are you sure you want to change the base?
Output predictor logs #12659
Conversation
I found a problem in saving out logs when the predictor is running so I proposed a solution which is a way to save the logs into a text file in a separate folder called LOGS, this solution helped a lot to get the logs in a text file and uses the logs file in my project.
All Contributors have signed the CLA. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @mohammadjadallah, thank you for submitting an Ultralytics YOLOv8 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with
ultralytics/ultralytics
main
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge main
locally. - ✅ Verify all YOLOv8 Continuous Integration (CI) checks are passing.
- ✅ Update YOLOv8 Docs for any new or updated features.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
See our Contributing Guide for details and let us know if you have any questions!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12659 +/- ##
==========================================
- Coverage 74.77% 70.94% -3.84%
==========================================
Files 122 123 +1
Lines 15631 15570 -61
==========================================
- Hits 11688 11046 -642
- Misses 3943 4524 +581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I sign the CLA |
@mohammadjadallah thanks for opening a PR! Just a quick note, instead of importing |
Thanks for your note I will do it. |
Thanks for the update and for being open to making the suggested adjustments! If you need any guidance with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented Logging Solution with pathlib.Path
- Utilized pathlib.Path for handling log file paths.
- Modified the script to save logs in a separate LOGS directory.
- Ensured the log file is correctly created and written using pathlib.
I found a problem in saving out logs when the predictor is running so I proposed a solution which is a way to save the logs into a text file in a separate folder called LOGS, this solution helped a lot to get the logs in a text file and uses the logs file in my project.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Introducing enhanced logging capabilities for better tracking and debugging.
📊 Key Changes
os
library to interact with the operating system.START_TIME
to assist with log file management.🎯 Purpose & Impact
With these changes, both developers and users gain a valuable tool to enhance performance monitoring and troubleshooting, leading to more efficient and effective model operation.