Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Unmovable scroll bar in the tablist section #2293

Open
2 tasks done
noornee opened this issue May 11, 2024 · 12 comments · May be fixed by #2304
Open
2 tasks done

Weird Unmovable scroll bar in the tablist section #2293

noornee opened this issue May 11, 2024 · 12 comments · May be fixed by #2304
Labels
bug Something isn't working

Comments

@noornee
Copy link

noornee commented May 11, 2024

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

There's a scrollbar-like bar appearing in my request tablist. (Check Screenshot)
noticed this too in v1.16.1

.bru file to reproduce the bug

No response

Screenshots/Live demo link

bruno-ui-bug

@noornee noornee added the bug Something isn't working label May 11, 2024
@busy-panda
Copy link
Contributor

busy-panda commented May 13, 2024

On which OS, mac, windows or linux ?

@noornee
Copy link
Author

noornee commented May 13, 2024

On which OS, mac, windows or linux ?

Linux.

@busy-panda
Copy link
Contributor

has anyone else the problem ?
i don't but i am on windows

@pietrygamat
Copy link
Contributor

pietrygamat commented May 13, 2024

On which OS, mac, windows or linux ?

Linux.

Looks like a custom DE theming problem. Are you using native or flatpak variant? I'd hope flatpak will not be affected regardless of what customisations are happening in the DE.

@noornee
Copy link
Author

noornee commented May 13, 2024

Looks like a custom DE theming problem

wow, don't know why i didn't think it could be my theme. I'll try to remove it entirely to see if it's the cause. (my theme is Adwaita)

Are you using native or flatpak variant?

Hyprland is my WM and I use the native variant of bruno or at least the one that's in the nixpkgs repository.

[edit]: nope, it's not my theme.

@Its-treason
Copy link
Member

Its-treason commented May 13, 2024

I saw those scrollbars after upgrading Electron to version 29 on my Lazer fork. They were caused by weird Bruno styling and the Chrome update.

Maybe the variant from NixOS also upgraded Electron. @noornee Could you open Bruno's Chrome DevTools and check the Chrome / Electron version?

Edit: The changes in Its-treason@6412004 (RequestTabs/StyledWrapper.js) should fix it.

@noornee
Copy link
Author

noornee commented May 13, 2024

I saw those scrollbars after upgrading Electron to version 29 on my Lazer fork. They were caused by weird Bruno styling and the Chrome update.

ahhh, I see.

Maybe the variant from NixOS also upgraded Electron. @noornee Could you open Bruno's Chrome DevTools and check the Chrome / Electron version?

Sure. I just did and yep, you're right.
The electron version on my machine is v.29

electron_version

I will try to look into it tomorrow.

Alrightt, Thank you!

@Its-treason
Copy link
Member

@noornee
Copy link
Author

noornee commented May 14, 2024

I looked into the Nix build file: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix and the electron version in indeed overwritten:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix#L100-L112

Woww, pheww!.
Guess I'm going to open an issue in the nixpkgs repository to tell them to pin a specific version of electron for bruno.

Thanks for narrowing out the source of this bug @Its-treason 🕵️

By chance, do you know the version of electron that bruno uses or atleast the last working electron version that didn't affect bruno's request tablist ui?

I modified the bruno package file and tried to build it locally using electron v28 on my machine but i had some errors that i couldn't stay to resolve, was running late to school. I'll look into it properly when i get home though. my best bet is that it's because i replaced every occurrence of the word electron with electron_28 and it messed some things up

@busy-panda
Copy link
Contributor

I managed to reproduce it using the latest version of electron and I see how to fix it, I am making a PR

busy-panda added a commit to busy-panda/bruno that referenced this issue May 14, 2024
There is an unnecessary "overflow: scroll" on tabs, and scrollbars appear when a more recent version of electron is used.
@noornee
Copy link
Author

noornee commented May 14, 2024

I managed to reproduce it using the latest version of electron and I see how to fix it, I am making a PR

that's awesome!

@busy-panda
Copy link
Contributor

Can I ask you @Its-treason to review my PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants