-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird Unmovable scroll bar in the tablist section #2293
Comments
On which OS, mac, windows or linux ? |
Linux. |
has anyone else the problem ? |
Looks like a custom DE theming problem. Are you using native or flatpak variant? I'd hope flatpak will not be affected regardless of what customisations are happening in the DE. |
wow, don't know why i didn't think it could be my theme. I'll try to remove it entirely to see if it's the cause. (my theme is Adwaita)
Hyprland is my WM and I use the native variant of bruno or at least the one that's in the nixpkgs repository. [edit]: nope, it's not my theme. |
I saw those scrollbars after upgrading Electron to version 29 on my Lazer fork. They were caused by weird Bruno styling and the Chrome update. Maybe the variant from NixOS also upgraded Electron. @noornee Could you open Bruno's Chrome DevTools and check the Chrome / Electron version? Edit: The changes in Its-treason@6412004 ( |
ahhh, I see.
Sure. I just did and yep, you're right.
Alrightt, Thank you! |
I looked into the Nix build file: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix and the electron version in indeed overwritten: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix#L100-L112 |
Woww, pheww!. Thanks for narrowing out the source of this bug @Its-treason 🕵️ By chance, do you know the version of electron that bruno uses or atleast the last working electron version that didn't affect bruno's request tablist ui? I modified the bruno package file and tried to build it locally using electron v28 on my machine but i had some errors that i couldn't stay to resolve, was running late to school. I'll look into it properly when i get home though. my best bet is that it's because i replaced every occurrence of the word |
I managed to reproduce it using the latest version of electron and I see how to fix it, I am making a PR |
There is an unnecessary "overflow: scroll" on tabs, and scrollbars appear when a more recent version of electron is used.
that's awesome! |
Can I ask you @Its-treason to review my PR ? |
I have checked the following:
Describe the bug
There's a scrollbar-like bar appearing in my request tablist. (Check Screenshot)
noticed this too in v1.16.1
.bru file to reproduce the bug
No response
Screenshots/Live demo link
The text was updated successfully, but these errors were encountered: