Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Weird Unmovable scroll bar in the tablist section #2293 #2304

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

busy-panda
Copy link
Contributor

@busy-panda busy-panda commented May 14, 2024

Fixes #2293

There is an unnecessary "overflow: scroll" and "-webkit-scrollbar {display: none }" on tabs, and scrollbars appear when a more recent version of electron is used, where -webkit-scrollbar was removed

And as discovered by @Its-treason the nix build overwrite the electron version, that explain why some users see the scrollbars

I looked into the Nix build file: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix and the electron version in indeed overwritten:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix#L100-L112

The scrollbars don't appear with the current electron version thanks to :

&::-webkit-scrollbar {
      display: none;
    }

But it can be removed if "overflow: scroll" is removed

Description

Here is the demonstration that the overflow: scroll is causing the problem

bruno.mp4

This second video shows that removing overflow: scroll does not change anything with the current electron version, so there is no regression.

bruno2.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

There is an unnecessary "overflow: scroll" on tabs, and scrollbars appear when a more recent version of electron is used.
@busy-panda busy-panda marked this pull request as ready for review May 14, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird Unmovable scroll bar in the tablist section
1 participant