Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add now function #456

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add now function #456

wants to merge 1 commit into from

Conversation

pradeepnnv
Copy link

@pradeepnnv pradeepnnv commented Feb 24, 2023 •
edited by xdlbdy

What problem does this PR solve?

Issue Number: close #430

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@pradeepnnv
add now function
863ed0c 
Signed-off-by: pradeepnnv <pradeepnnv@gmail.com>
@pradeepnnv pradeepnnv marked this pull request as draft February 24, 2023 03:09
@xdlbdy xdlbdy mentioned this pull request Feb 25, 2023
Open
@xdlbdy
Copy link
Contributor

xdlbdy commented Feb 25, 2023

the path is the target path, it isn't the original path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

@ifplusor ifplusor Awaiting requested review from ifplusor ifplusor will be requested when the pull request is marked ready for review ifplusor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good First Issues]: implement function "now" - 4 points
2 participants
@pradeepnnv @xdlbdy