Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MapTiler integration #8778

Closed
wants to merge 1 commit into from
Closed

Add MapTiler integration #8778

wants to merge 1 commit into from

Conversation

bolollo
Copy link

@bolollo bolollo commented Apr 10, 2024

Closes #8777

Background

Add MapTiler in Supported Base Maps and create examples using MapTiler SDK js

Change List

Create new pages:

  • /docs/developer-guide/base-maps/using-with-maptiler
  • /examples (new integration example)
  • /examples/get-started/pure-js/maptiler
  • /examples/get-started/react/maptiler
  • /gallery/maptiler-overlay

Update:

  • docs/get-started/using-with-map

Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. There's a lot to unpack here:

  • New get-started examples are always welcomed
  • Each website integration example is expected to have merits of its own, e.g. showcasing the unique capability of the base map and/or integration approach, an interesting dataset, etc. We do not accept identical copy of another existing example.
  • Similarly, each documentation page is expected to have merits of its own. This PR just copied and made some replacements of an (outdated) Mapbox page. There is now a dedicated using with Maplibre page and, as far as I can tell, MapTiler SDK is only a thin wrapper of Maplibre. I am in favor of adding a section to the Maplibre page regarding compatible libraries (MapTiler, Azure Maps, etc.)
  • Should we accept it, any new secret added to the website must be managed by the Technical Steering Committee, as a missing secret will cause the automated publish process to fail.

@coveralls
Copy link

Coverage Status

coverage: 89.996%. remained the same
when pulling d90b628 on bolollo:maptiler
into bddd4cc on visgl:master.

@Pessimistress
Copy link
Collaborator

Closing this as it does not meet our guidelines for documentation and examples. Please redirect any discussion to the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MapTiler in Supported Base Maps [Doc]
3 participants