Introduce WeaviateAsyncClient as async alternative to WeaviateClient
#1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes base implementation to be purely async using `httpx` and `grpclib`(instead of google's grpc due to [issues](grpc/grpc#25364)) - Uses base implementation in `WeaviateAsyncClient` directly - Subdivides the codebase into `**/asy/*.py` and `**/sy/*.py` directories within each namespace directory - Replace `WeaviateClient` internal calls with event-loop-wrapped blocking calls using the base async implementation - `WeaviateClient` spins up its own personal event loop thread that it schedules async calls to. Should this be a global singleton instead? - `client.batch` is only available on the `WeaviateClient` object, since it is a purely sync algorithm. It depends on the new higher-level event loop thread
|
Great to see you again! Thanks for the contribution. |
|
I'm following this as well. I'm looking forward to the async client :) |
…ient into implement-async-client
…ient into implement-async-client
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 94.62% 94.37% -0.25%
==========================================
Files 182 197 +15
Lines 18870 19548 +678
==========================================
+ Hits 17855 18449 +594
- Misses 1015 1099 +84 ☔ View full report in Codecov by Sentry. |
dirkkul
requested changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpxandgrpclib(instead of google's grpc due to issues)WeaviateAsyncClientdirectlyWeaviateClientinternal calls with event-loop-wrapped blocking calls using the base async implementationclient.batchis only available on theWeaviateClientobject, since it is a purely sync algorithm. It depends on the new higher-level event loop thread