fix: set status on error with progressive fallback #11054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7fa8656 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
May 16, 2024
|
Tests are failing consistently 🤔 |
bluwy
reviewed
May 17, 2024
Comment on lines
52
to
56
| return new Response(response.body, { | ||
| status: result.error.status, | ||
| statusText: result.error.message, | ||
| headers: response.headers, | ||
| }) |
There was a problem hiding this comment.
Maybe we should return a simplified statusText for prod? In #10284, it was considered a vulnerability that the error message was shown to the users.
There was a problem hiding this comment.
Good point. I also realized statusText does not support special characters like newlines. To keep things simple, I'll just out the error.name here, which is just the status code written out like NOT_FOUND. No need for prod security checks I don't think
bholmesdev
force-pushed
the
fix/set-status-on-progressive-fallback
branch
from
b6442fd
to
770c771
Compare
ematipico
approved these changes
May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Respect error status when using a progressive fallback. This will overwrite any
statusset from Astro frontmatter withresponse.status. Curious if we think this makes sense?Testing
Already have e2e test for progressive fallback validation errors. It doesn't check the status, but this is difficult to assert.
Docs
N/A