Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump beta tester to 2.3.1 to prep a new release #47427

Merged
merged 3 commits into from
May 15, 2024

Conversation

moon0326
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Bump the version of beta tester to 2.3.1 to include Remote Spec Validator

How to test the changes in this Pull Request:

Make sure version is updated in all the required places.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Bump the version of beta tester to 2.3.1 to include Remote Spec Validator

Comment

@moon0326 moon0326 requested review from a team, chihsuan and adrianduffell May 13, 2024 17:40
@github-actions github-actions bot added focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. labels May 13, 2024
Copy link
Contributor

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 13, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moon0326 , version bump looks good!

Should we include all changelogs in the changelog folder? https://github.com/woocommerce/woocommerce/tree/0f38156f238fb25c182e9ee7d06d5a0167f12c33/plugins/woocommerce-beta-tester/changelog

@moon0326
Copy link
Contributor Author

Thanks @moon0326 , version bump looks good!

Should we include all changelogs in the changelog folder? https://github.com/woocommerce/woocommerce/tree/0f38156f238fb25c182e9ee7d06d5a0167f12c33/plugins/woocommerce-beta-tester/changelog

Good point! It looks like it's been added now.

@moon0326 moon0326 closed this May 14, 2024
@moon0326 moon0326 reopened this May 14, 2024
@chihsuan
Copy link
Member

Good point! It looks like it's been added now.

Sorry for the confusion, I was referring to existing changelog files in the changelog folder. I think we should include them in plugins/woocommerce-beta-tester/changelog.txt and delete them like this previous PR?

@moon0326
Copy link
Contributor Author

existing changelog files

Ah I see. I'll go through them 👍

@moon0326
Copy link
Contributor Author

Good point! It looks like it's been added now.

Sorry for the confusion, I was referring to existing changelog files in the changelog folder. I think we should include them in plugins/woocommerce-beta-tester/changelog.txt and delete them like this previous PR?

@chihsuan Updated in Update readme.txt and clean up old changelog files

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! 🚀

@moon0326 moon0326 merged commit bcd80f4 into trunk May 15, 2024
15 checks passed
@moon0326 moon0326 deleted the dev/bump-beta-tester-version branch May 15, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants