Probably useless call to maybe_read_meta_data() in WC_Data::get_meta()

[tivnet]

$this->maybe_read_meta_data(); already in

public function get_meta_data() {
		$this->maybe_read_meta_data();

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[Konamiman]

Hi @tivnet, thanks for your contribution. The change you suggest seems good, but we require pull requests to include testing instructions, could you please add them?

[tivnet]

@Konamiman Hola Néstor, this is trivial and does not need any testing. Thanks!

[Konamiman]

@tivnet Yes, I know it's a trivial change, but we really require testing instructions for any pull request that is merged into core and contains actual code changes (documentation related pull requests are different of course). We have internal processes in place for each WooCommerce release, and this includes a quality assurance process that makes use of these instructions.

It doesn't need to be anything complicated, just something that makes the code run to verify that it doesn't break. Maybe even running the method from command line.

Thanks for your understanding and patience!

[Konamiman]

Also @tivnet there are a few CI checks failing, could you please rebase the branch from the latest trunk?