Fix: handle undefined templateSlug in Product Collection tracking utils #47504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modification introduces a check for templateSlug before attempting to access its properties or use it in further logic. This change addresses a bug that manifested when users tried to edit a synchronized Product Collection block, resulting in a JavaScript error because templateSlug could be undefined.
imanish003
added
type: bug
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
Hi @xristos3490, @kmanijak, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
github-actions
bot
added
the
plugin: woocommerce
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
kmanijak
approved these changes
May 15, 2024
11 tasks
…tern-with-product-collection-block
…tern-with-product-collection-block
imanish003
deleted the
47502-issue-error-when-editing-a-synced-pattern-with-product-collection-block
branch
github-actions
bot
added
the
needs: analysis
alvarothomas
added
needs: external testing
alvarothomas
added
the
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The modification introduces a check for templateSlug before attempting to access its properties or use it in further logic. This change addresses a bug that manifested when users tried to edit Product Collection block in Sync Pattern, resulting in a JavaScript error because templateSlug could be undefined.
Closes #47502
How to test the changes in this Pull Request:
Go to "Products by category" template & add product collection block to it.
Create a sync pattern with Product Collection block inside it.
Select sync pattern and click on "Edit original" in toolbar as shown in screenshot below
Verify that the following error isn't occurring when the Sync pattern is loaded in Editor.
Developer only testing: Verify that you are able to reproduce this issue on
trunkbut not on this PR branch.Changelog entry
Significance
Type
Message
Fix: handle undefined templateSlug in Product Collection tracking utils
Comment