Replace ImageOpenDialog by gtk4-compatible version #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhennion
force-pushed
the
pr/OpenImageDlg
branch
from
aa8134c
to
c468236
Compare
bhennion
force-pushed
the
pr/OpenImageDlg
branch
2 times, most recently
from
78bfa6e
to
9c589a9
Compare
|
Rebased on latest master, now that #5602 has been merged. There was no conflicts. |
|
It still looks good to me. I suggest to go ahead and merge. |
Thanks for the review!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is based on both #5602 and #5630.
It refactors the last of the blocking dialog (except the toolbar customization, which can't be pre-ported to gtk4).