Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest integration/testing foundation layer #164

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

print-VarunSharma
Copy link

Pull Request Type

Dictionary of Definitions here

  • Just a heads up πŸ™†
  • Sanity check πŸƒβ€β™‚οΈ
  • Work in progress (WIP) πŸ—οΈ
  • Early feedback ✍️
  • Line-by-line review πŸ“
  • Pull request to a pull request πŸ”€

Description

This PR addresses the feature request issue via here: #163 .

The motivation for this PR is that as a styleTTS2 contributor/user I want to be able to run tests to ensure that my code doesn't break anything critical, as well as if myself or other contributors fix a bug/issue, we want regression testing, and the ability to encode the bug fix reflected in the tests.

More BG info on this in the aforementioned tagged issue.

The small amount of base unit tests was intended as this PR's main aims is to integrate pytest, offer a clean folder structure for the tests, and additional useful documentation.

Screenshots

The test suite is working as intended! πŸš€
image

PyTest
image

Context Links

  • Add links & resources such as documentation of libraries, etc.
  • PyTest

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Extended the README / documentation, if necessary
  • Do we need to implement analytics?
  • My changes generate no new warnings
  • Is the code readable? Prefer to see more self-explanatory and consistency
  • Is the code tested properly? i.e. where appropriate, we're testing well-explained failures, behaviours, fixes, etc

Caveats/Notes

Talk about things reviewers should be aware about
(Please include here if you created a new environment variables and ensure you have communicated this secret to the team)

I believe in the boy scout mentality (leave your camp site cleaner than you found it) so I removed some dead/unused imports and code in the relevant files that I touched.

Prompts

  • Where would you like the reviewer to focus their energy on?
  • Any particular areas of code that you'd like to reduce complexity, technical debt, risk, or needs further optimization?

Let me know feedback about this, and what else would folks like to see. I think pytests should be more than sufficient for unit and integration tests. For more training and model specific tests, something like PyTorch Ignite could be used.

@yl4579
Copy link
Owner

yl4579 commented Dec 22, 2023

Thanks for your contribution. Could you explain a little more what changes you have made in your PR?

Akito-UzukiP pushed a commit to Akito-UzukiP/StyleTTS2 that referenced this pull request Jan 13, 2024
* Feat: use diy loguru logger

* Feat: use diy loguru logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants