Retain run loop #11241
Merged
Retain run loop #11241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes: #11168
cla-bot
bot
added
the
cla-signed
1 task
luckydye
pushed a commit
to luckydye/zed
that referenced
this pull request
May 2, 2024
Contributes: zed-industries#11168 https://developer.apple.com/documentation/corefoundation/1542428-cfrunloopgetcurrent implies that we should be `CFRetain`ing the run loop. Lets do that, and see if it reduces the number of crashes we see. Release Notes: - (maybe) Fix a rare crash in watching settings files.
ConradIrwin
added a commit
that referenced
this pull request
May 2, 2024
Contributes: #11168 https://developer.apple.com/documentation/corefoundation/1542428-cfrunloopgetcurrent implies that we should be `CFRetain`ing the run loop. Lets do that, and see if it reduces the number of crashes we see. Release Notes: - (maybe) Fix a rare crash in watching settings files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes: #11168
https://developer.apple.com/documentation/corefoundation/1542428-cfrunloopgetcurrent
implies that we should be
CFRetaining the run loop.Lets do that, and see if it reduces the number of crashes we see.
Release Notes: