Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix selling jump drives to the unfettered #9911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NPN26
Copy link

@NPN26 NPN26 commented Mar 12, 2024

Bug fix

This PR addresses the bug described in issue #9902

Summary

Duplicated the story line to check if players has a hyperdrive installed already to prevent them from getting another hyperdrive. I haven't been able to test since I don't have a save file to check it.

Performance Impact

N/A

added bugfix for getting extra hyper drive for trading jump drive with unfettered Hai
@Hurleveur
Copy link
Member

Hurleveur commented Mar 12, 2024

Thanks for getting to it but actually it isnt required to duplicate it, we can just have a branch that leads to 2 different action nodes

edit: also it isnt just the first mission that's concerned, but all 4, and ideally we'd update the dialog to not say the JD is installed

@warp-core
Copy link
Contributor

I don't think making a second copy of these missions for this is a great approach.
You can probably use branches and actions within the conversation to only give the hyperdrive if one isn't already installed.
Regardless of how it is done, if a hyperdrive is not provided, the payment should have the fully depreciated price off a hyperdrive in addition to the base million credits.

Alternatively, the "outfit" node in GameAction could be expanded to support children that might specify where to try to put the outfit. Or to only install it if the player has fewer than a certain number of it.

@quyykk quyykk added bug Something in the game is not behaving as intended content A suggestion for new content that doesn't require code changes labels Mar 12, 2024
@warp-core warp-core added the waiting on OP The OP needs to provide something, e.g, making requested changes, posting assets, etc. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something in the game is not behaving as intended content A suggestion for new content that doesn't require code changes waiting on OP The OP needs to provide something, e.g, making requested changes, posting assets, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants