Major new UI redesign #2302
Closed
Major new UI redesign #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manyoso
force-pushed
the
major_new_ui_redesign
branch
from
ca9d368
to
1a26c7a
Compare
manyoso
added a commit
that referenced
this pull request
May 7, 2024
…sending mixpanel events. These changes added complexity to the Database code which we're looking to simplify not increase complexity and all info that we care about from mixpanel should be available from the GUI thread. NOTE: This change will not compile by itself. It must be included with subsequent changes made in PR #2302 but is here broken out into a standalone commit to aid in review. Signed-off-by: Adam Treat <treat.adam@gmail.com>
manyoso
added a commit
that referenced
this pull request
May 7, 2024
…state of the major ui design change branch. It will be broken up into smaller pieces to aid in review in further work. This is a DRAFT PR for #2302 Signed-off-by: Adam Treat <treat.adam@gmail.com>
manyoso
force-pushed
the
major_new_ui_redesign
branch
2 times, most recently
from
38d1c04
to
cf4e525
Compare
Signed-off-by: Adam Treat <treat.adam@gmail.com>
…sending mixpanel events. These changes added complexity to the Database code which we're looking to simplify not increase complexity and all info that we care about from mixpanel should be available from the GUI thread. NOTE: This change will not compile by itself. It must be included with subsequent changes made in PR #2302 but is here broken out into a standalone commit to aid in review. Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
…ut of date. Signed-off-by: Adam Treat <treat.adam@gmail.com>
…eaking
change that requires re-indexing of all collections.
- Adds a general mechanism for handling breaking changes to localdocs database
upgrades
- Upgrades the database format to version 2 and includes numerous changes to
the underlying tables including:
a) adds word and token count fields for chunk table
b) adds a boolean field indicating whether the chunk has a generated embedding
c) adds a last updated time field for collection table which can be displayed in GUI
d) adds an embedding model field for collection table
e) adds a boolean field for collection table to allow forced re-indexing
- Adds several statistics about the collection which can be displayed in GUI
a) total documents
b) total words
c) total tokens
d) last updated time
e) which document is currently being indexed
f) which document is currently being embedded
g) which model is being used to generate embeddings for the collection
- Simplifies communication between the database thread and the GUI thread
removing a lot of extra code and makes clear what methods/signals in database
class are soley used for communicating state to the GUI
- Provides a pool for sending embedding requests to the embedding thread to
increase speed of embedding when the chunks per document are small
- Provides a mechanism for resuming indexing/embedding when the app shutsdown
or crashes in the middle of indexing/embedding
NOTE: This change is part of a larger set of commits, but can be built and
compiles up to this point
Signed-off-by: Adam Treat <treat.adam@gmail.com>
follows the new FIGMA design made by Vincent. It also contains a lot of changes to the way localdocs works. This is now rebased on top of main and conflicts resolved. This is still a monolithic commit that needs to be broken up into smaller pieces in order to aid proper review. I'll be working on that now and force pushing as I do so. Signed-off-by: Adam Treat <treat.adam@gmail.com>
manyoso
force-pushed
the
major_new_ui_redesign
branch
from
cf4e525
to
c7b0812
Compare
manyoso
added a commit
that referenced
this pull request
May 16, 2024
…sending mixpanel events. These changes added complexity to the Database code which we're looking to simplify not increase complexity and all info that we care about from mixpanel should be available from the GUI thread. NOTE: This change will not compile by itself. It must be included with subsequent changes made in PR #2302 but is here broken out into a standalone commit to aid in review. Signed-off-by: Adam Treat <treat.adam@gmail.com>
manyoso
added a commit
that referenced
this pull request
May 16, 2024
…sending mixpanel events. These changes added complexity to the Database code which we're looking to simplify not increase complexity and all info that we care about from mixpanel should be available from the GUI thread. NOTE: This change will not compile by itself. It must be included with subsequent changes made in PR #2302 but is here broken out into a standalone commit to aid in review. Signed-off-by: Adam Treat <treat.adam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR. It reflects a lot of major new ui redesign work that follows the new FIGMA design made by Vincent. It also contains a lot of changes to the way localdocs works.
This is now rebased on top of main and conflicts resolved. This is still a monolithic commit that needs to be broken up into smaller pieces in order to aid proper review. I'll be working on that now and force pushing as I do so.