Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major new UI redesign #2302

Closed
wants to merge 7 commits into from
Closed

Major new UI redesign #2302

wants to merge 7 commits into from

Commits on May 9, 2024

  1. Fix destruction and tear down of the embedding thread. 

    Signed-off-by: Adam Treat <treat.adam@gmail.com>
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f40e9c1 View commit details
    Browse the repository at this point in the history

  2. Back out some of the changes that were added to localdocs to support … 

    …sending

mixpanel events. These changes added complexity to the Database code which
we're looking to simplify not increase complexity and all info that we care
about from mixpanel should be available from the GUI thread.

NOTE: This change will not compile by itself. It must be included with subsequent
changes made in PR #2302 but is here broken out into a standalone commit
to aid in review.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d6d3481 View commit details
    Browse the repository at this point in the history

  3. Add a FIXME for the current hardcoding of the dimension for the index. 

    Signed-off-by: Adam Treat <treat.adam@gmail.com>
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3221b57 View commit details
    Browse the repository at this point in the history

  4. Remove the debug example in database as it's now too simplistic and o… 

    …ut of date.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6597a46 View commit details
    Browse the repository at this point in the history

  5. Large update to localdocs with many moving parts. This commit is a br… 

    …eaking

change that requires re-indexing of all collections.

- Adds a general mechanism for handling breaking changes to localdocs database
  upgrades

- Upgrades the database format to version 2 and includes numerous changes to
  the underlying tables including:
    a) adds word and token count fields for chunk table
    b) adds a boolean field indicating whether the chunk has a generated embedding
    c) adds a last updated time field for collection table which can be displayed in GUI
    d) adds an embedding model field for collection table
    e) adds a boolean field for collection table to allow forced re-indexing

- Adds several statistics about the collection which can be displayed in GUI
    a) total documents
    b) total words
    c) total tokens
    d) last updated time
    e) which document is currently being indexed
    f) which document is currently being embedded
    g) which model is being used to generate embeddings for the collection

- Simplifies communication between the database thread and the GUI thread
  removing a lot of extra code and makes clear what methods/signals in database
  class are soley used for communicating state to the GUI

- Provides a pool for sending embedding requests to the embedding thread to
  increase speed of embedding when the chunks per document are small

- Provides a mechanism for resuming indexing/embedding when the app shutsdown
  or crashes in the middle of indexing/embedding

NOTE: This change is part of a larger set of commits, but can be built and
compiles up to this point
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f888a9f View commit details
    Browse the repository at this point in the history

  6. Add several new icons and change current set. 

    Signed-off-by: Adam Treat <treat.adam@gmail.com>
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    42615ea View commit details
    Browse the repository at this point in the history

  7. This is a draft PR. It reflects a lot of major new ui redesign work that 

    follows the new FIGMA design made by Vincent. It also contains a lot of
changes to the way localdocs works.

This is now rebased on top of main and conflicts resolved. This is still
a monolithic commit that needs to be broken up into smaller pieces in order
to aid proper review. I'll be working on that now and force pushing as I
do so.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
    @manyoso
    manyoso committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c7b0812 View commit details
    Browse the repository at this point in the history