-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --rune flag to resume command to enable resuming a specific etching #3679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good feature.
We should probably resume it by rune name. Another feature that would improve this would be a command to list all pending etchings, so it is easier to know what can be resumed. Probably best to do another PR for that.
Thanks for the feedback, @raphjaph! Requested changes have been applied. I've also fixed linting issues. Will add the command to show pending etchings on a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Still needs an integration test. Have a look at tests/wallet/resume.rs
. For reasons this can only be tested on Mac and Linux. What system are you on?
@raphjaph took me a while to get around to adding these tests, but here they are! Hope it's looking good. I'm on a Mac, btw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
Adds a new
--rune <RUNE>
flag to allow resuming a specific pending etching. This is useful in automated scenarios (if anyone else is into that kind of stuff) where you'd like to etch something, suspend (perhaps via--no-wait
from #3526), do something else, and then resume after the 6 confirmations.